Conversation
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
36f0b1f to
ef8a2a2
Compare
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 36f0b1f in 2 minutes and 18 seconds. Click for details.
- Reviewed
97lines of code in5files - Skipped
2files when reviewing. - Skipped posting
13draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/autofix.yml:40
- Draft comment:
Updated autofix-ci action digest to 635ffb0c9798bd160680f18fd73371e355b85f27. Please verify that this update remains compatible with your workflow and does not introduce any unexpected behavior. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to verify compatibility and check for unexpected behavior, which violates the rule against asking for confirmation or verification. It does not provide a specific suggestion or point out a specific issue.
2. .github/workflows/ci.yml:43
- Draft comment:
Codecov action has been updated to digest 18283e04ce6e62d37312384ff67231eb8fd56d24 (v5.4.3). Review the changelog to ensure the changes (e.g. OIDC fixes) do not impact your coverage reporting. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative and asks the PR author to review the changelog, which violates the rules against making purely informative comments and asking the author to double-check things.
3. .nvmrc:1
- Draft comment:
Node version updated to 22.17.0. Confirm that this aligns with the project's engine requirements and that all dependencies are compatible with this version. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to confirm compatibility with the project's engine requirements and dependencies, which violates the rule against asking for confirmation or ensuring compatibility. It does not provide a specific suggestion or point out a specific issue.
4. .yarnrc.yml:10
- Draft comment:
Yarn path updated to use yarn-4.9.2.cjs. Ensure that the new Yarn version is fully compatible with your build scripts and plugins. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to ensure compatibility of the new Yarn version with build scripts and plugins, which falls under the rule of not asking the author to ensure or verify things. It does not provide a specific suggestion or point out a specific issue.
5. package.json:15
- Draft comment:
The packageManager field has been updated to 'yarn@4.9.2'. This change is consistent with the Yarn upgrade in .yarnrc.yml. Confirm that this version suits the project's requirements. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is related to a dependency change, specifically the package manager version. It asks the author to confirm if the version suits the project's requirements, which is against the rules. The comment does not provide a specific suggestion or highlight a potential issue with the change.
6. package.json:59
- Draft comment:
Dependency 'find-up' has been updated to ^7.0.0. Note that version 7 is now pure ESM and requires Node 18+. Since the project is CommonJS-based, verify that the way 'find-up' is imported and used remains compatible. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment raises a valid compatibility concern, but the project already requires Node 18+ and explicitly declares itself as CommonJS. The package.json shows this is a well-maintained project with careful version management. The maintainers likely knew what they were doing with this update. The comment identifies a real technical consideration. Maybe the maintainers weren't aware of the ESM change? The project's explicit CommonJS type and Node version requirements suggest this was an intentional update with awareness of the implications. Delete the comment. It violates the rule about not asking for verification, and the project setup suggests the maintainers are already aware of the compatibility requirements.
7. package.json:60
- Draft comment:
Dependency 'glob' has been updated to ^11.0.0. Review its changelog for any breaking changes affecting glob patterns or its API. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is about a dependency change and suggests reviewing the changelog for breaking changes. According to the rules, comments on dependency changes should be ignored, especially if they are about versions or changelogs.
8. package.json:65
- Draft comment:
Dependency 'yargs' has been updated to ^18.0.0. Check for any major changes in the API that might affect command-line parsing in the CLI. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is about a dependency update, specifically 'yargs', and suggests checking for major changes in the API. This falls under the rule of not commenting on dependency changes or library versions that are not recognized. The comment does not provide a specific suggestion or point out a specific issue with the code.
9. package.json:68
- Draft comment:
Updated '@1stg/eslint-config' to ^10.0.0. This major bump may include breaking changes in ESLint rules/configurations, so verify that linting behaves as expected. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is about a dependency update and suggests verifying the behavior, which violates the rules. It doesn't provide a specific code suggestion or ask for a specific test to be written.
10. package.json:76
- Draft comment:
Updated '@types/jest' to ^30.0.0. Ensure that the new type definitions are compatible with your existing tests. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is related to a dependency change, specifically updating the '@types/jest' package. The comment asks the author to ensure compatibility, which is against the rules. Therefore, this comment should be removed.
11. package.json:80
- Draft comment:
Updated 'eslint-plugin-jest' to ^29.0.0. Review the plugin's changelog for rule adjustments or deprecated features that might affect your tests. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is about a dependency change, specifically updating a plugin version. It suggests reviewing the changelog for potential issues, which falls under the category of asking the author to double-check things. This violates the rule against commenting on dependency changes or asking the author to ensure behavior is intended.
12. package.json:82
- Draft comment:
Updated 'jest' to ^30.0.0. Since this is a major version bump, run your test suite to ensure no regressions or breaking changes have been introduced. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is about a dependency update and suggests running tests to ensure no regressions. It violates the rule against commenting on dependency changes and asking the author to ensure the change is tested.
13. package.json:86
- Draft comment:
Updated 'pify' to ^6.0.0. Verify that any changes in its API are properly handled in the code. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to verify changes in the API of a dependency, which is not allowed according to the rules. It does not provide a specific suggestion or point out a specific issue.
Workflow ID: wflow_Z4EEXq7l5QmKdcVe
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
ef8a2a2 to
8b195d2
Compare
220246f to
0ca26a9
Compare
0ca26a9 to
bf25904
Compare
bf25904 to
7f652b0
Compare
4e9f01b to
80654bb
Compare
0e4ceaa to
36f963b
Compare
392c682 to
433eedb
Compare
3afb35b to
1ca2e45
Compare
1ca2e45 to
3d2234c
Compare
3d2234c to
1b067e2
Compare
771d351 to
ac9d344
Compare
f0b141e to
9b628a4
Compare
9b628a4 to
91c0dc3
Compare
91c0dc3 to
98b8758
Compare
98b8758 to
ad6ee9f
Compare
3a1202d to
fd6a069
Compare
34b364c to
78e2c60
Compare
3e255ea to
7acdec8
Compare
9ba016d to
28ac33c
Compare
d5b2344 to
9fc886f
Compare
9fc886f to
4b92c70
Compare
4b92c70 to
36c0e90
Compare
This PR contains the following updates:
^9.0.6→^10.0.0^29.5.14→^30.0.0v4.2.2→v6.0.2v4.4.0→v6.2.0v9.1.0→v10.1.12891949→7a166d7v5.4.2→v5.5.2^9.26.0→^10.0.0^28.11.0→^29.0.0^5.0.0→^8.0.0^29.7.0→^30.0.0^0.8.0→^0.9.022.15.0→24.13.0^5.0.0→^6.0.0^17.7.2→^18.0.04.9.1→4.12.0Release Notes
1stG/configs (@1stg/eslint-config)
v10.2.0Compare Source
Minor Changes
4c2cbd7Thanks @renovate! - chore(deps): update all upgradable pluginsPatch Changes
a7ee3ee]:v10.1.0Compare Source
Minor Changes
ed8b7e5Thanks @JounQin! - feat: enableeslint-plugin-node-dependenciesconditionallyPatch Changes
#377
ed8b7e5Thanks @JounQin! - fix: declare node engines range correctlyUpdated dependencies [
ed8b7e5]:v10.0.0Compare Source
Major Changes
6561a5eThanks @JounQin! - chore: bump all upgradable (dev)DependenciesPatch Changes
6561a5e]:v9.1.0Compare Source
Minor Changes
#370
85d8686Thanks @JounQin! - feat: addeslint-plugin-react-refreshsupport#367
94685f7Thanks @JounQin! - chore(eslint): bumpeslint-plugin-unicornto v59.0.1#369
5e8ada3Thanks @JounQin! - feat: migrateprojecttoprojectServicefor TypeScriptactions/checkout (actions/checkout)
v6.0.2Compare Source
v6.0.1Compare Source
v6.0.0Compare Source
v5.0.1Compare Source
What's Changed
Full Changelog: actions/checkout@v5...v5.0.1
v5.0.0Compare Source
What's Changed
v2.327.1
Release Notes
Make sure your runner is updated to this version or newer to use this release.
Full Changelog: actions/checkout@v4...v5.0.0
v4.3.1Compare Source
What's Changed
Full Changelog: actions/checkout@v4...v4.3.1
v4.3.0Compare Source
What's Changed
New Contributors
Full Changelog: actions/checkout@v4...v4.3.0
actions/setup-node (actions/setup-node)
v6.2.0Compare Source
v6.1.0Compare Source
What's Changed
Enhancement:
Dependency updates:
Documentation update:
Full Changelog: actions/setup-node@v6...v6.1.0
v6.0.0Compare Source
What's Changed
Breaking Changes
Dependency Upgrades
Full Changelog: actions/setup-node@v5...v6.0.0
v5.0.0Compare Source
What's Changed
Breaking Changes
This update, introduces automatic caching when a valid
packageManagerfield is present in yourpackage.json. This aims to improve workflow performance and make dependency management more seamless.To disable this automatic caching, set
package-manager-cache: falseMake sure your runner is on version v2.327.1 or later to ensure compatibility with this release. See Release Notes
Dependency Upgrades
New Contributors
Full Changelog: actions/setup-node@v4...v5.0.0
actions/stale (actions/stale)
v10.1.1Compare Source
What's Changed
Bug Fix
only-issue-typesby @Bibo-Joshi in #1298Improvement
Dependency Upgrades
New Contributors
Full Changelog: actions/stale@v10...v10.1.1
v10.1.0Compare Source
What's Changed
only-issue-typesoption to filter issues by type by @Bibo-Joshi in #1255New Contributors
Full Changelog: actions/stale@v10...v10.1.0
v10.0.0Compare Source
What's Changed
Breaking Changes
Make sure your runner is on version v2.327.1 or later to ensure compatibility with this release. Release Notes
Enhancement
Dependency Upgrades
Documentation changes
New Contributors
Full Changelog: actions/stale@v9...v10.0.0
codecov/codecov-action (codecov/codecov-action)
v5.5.2Compare Source
What's Changed
Full Changelog: https://github.com/codecov/codecov-action/compare/v5.5.1..v5.5.2
v5.5.1Compare Source
What's Changed
codecov-cliversion reference example by @webknjaz in #1774Full Changelog: https://github.com/codecov/codecov-action/compare/v5.5.0..v5.5.1
v5.5.0Compare Source
What's Changed
Full Changelog: https://github.com/codecov/codecov-action/compare/v5.4.3..v5.5.0
v5.4.3Compare Source
What's Changed
Full Changelog: https://github.com/codecov/codecov-action/compare/v5.4.2..v5.4.3
eslint/eslint (eslint)
v10.0.0Compare Source
v9.39.2Compare Source
v9.39.1Compare Source
v9.39.0Compare Source
v9.38.0Compare Source
Features
ce40f74feat: updatecomplexityrule to only highlight function header (#20048) (Atul Nair)e37e590feat: correctno-loss-of-precisionfalse positives withenotation (#20187) (Francesco Trotta)Bug Fixes
50c3dfdfix: improve type support for isolated dependencies in pnpm (#20201) (Francesco Trotta)a1f06a3fix: correct SourceCode typings (#20114) (Pixel998)Documentation
462675adocs: improve web accessibility by hiding non-semantic character (#20205) (루밀LuMir)c070e65docs: correct formatting inno-irregular-whitespacerule documentation (#20203) (루밀LuMir)b39e71adocs: Update README (GitHub Actions Bot)cd39983docs: movecustom-formatterstype descriptions tonodejs-api(#20190) (Percy Ma)Chores
d17c795chore: upgrade @eslint/js@9.38.0 (#20221) (Milos Djermanovic)25d0e33chore: package.json update for @eslint/js release (Jenkins)c82b5efrefactor: Use types from @eslint/core (#20168) (Nicholas C. Zakas)ff31609ci: add Node.js 25 toci.yml(#20220) (루밀LuMir)004577eci: bump github/codeql-action from 3 to 4 (#20211) (dependabot[bot])eac71fbtest: remove use ofnodejsScopeoption of eslint-scope from tests (#20206) (Milos Djermanovic)4168a18chore: fix typo in legacy-eslint.js (#20202) (Sweta Tanwar)205dbd2chore: fix typos (#20200) (ntnyq)dbb200echore: use team member's username when name is not available in data (#20194) (Milos Djermanovic)8962089chore: mark deprecated rules as available until v11.0.0 (#20184) (Pixel998)v9.37.0Compare Source
Features
39f7fb4feat:preserve-caught-errorshould recognize all static "cause" keys (#20163) (Pixel998)f81eabcfeat: support TS syntax inno-restricted-imports(#19562) (Nitin Kumar)Bug Fixes
a129ccefix: correctno-loss-of-precisionfalse positives for leading zeros (#20164) (Francesco Trotta)09e04fcfix: add missing AST token types (#20172) (Pixel998)861c6dafix: correctESLinttypings (#20122) (Pixel998)Documentation
b950359docs: fix typos across the docs (#20182) (루밀LuMir)42498a2docs: improve ToC accessibility by hiding non-semantic character (#20181) (Percy Ma)29ea092docs: Update README (GitHub Actions Bot)5c97a04docs: showavailableUntilin deprecated rule banner (#20170) (Pixel998)90a71bfdocs: updateREADMEfiles to add badge and instructions (#20115) (루밀LuMir)1603ae1docs: update references frommastertomain(#20153) (루밀LuMir)Chores
afe8a13chore: update@eslint/jsdependency to version 9.37.0 (#20183) (Francesco Trotta)abee4cachore: package.json update for @eslint/js release (Jenkins)fc9381fchore: fix typos in comments (#20175) (overlookmotel)e1574a2chore: unpin jiti (#20173) (renovate[bot])e1ac05erefactor: markESLint.findConfigFile()asasync, add missing docs (#20157) (Pixel998)347906dchore: update eslint (#20149) (renovate[bot])0cb5897test: remove tmp dir created for circular fixes in multithread mode test (#20146) (Milos Djermanovic)bb99566ci: pinjitito version 2.5.1 (#20151) (Pixel998)177f669perf: improve worker count calculation for"auto"concurrency (#20067) (Francesco Trotta)448b57bchore: Mark deprecated formatting rules as available until v11.0.0 (#20144) (Milos Djermanovic)v9.36.0Compare Source
Features
47afcf6feat: correctpreserve-caught-erroredge cases (#20109) (Francesco Trotta)Bug Fixes
75b74d8fix: add missing rule option types (#20127) (ntnyq)1c0d850fix: updateeslint-all.jsto useObject.freezeforrulesobject (#20116) (루밀LuMir)7d61b7ffix: add missing scope types toScope.type(#20110) (Pixel998)7a670c3fix: correct rule option typings inrules.d.ts(#20084) (Pixel998)Documentation
b73ab12docs: update examples to usedefineConfig(#20131) (sethamus)31d9392docs: fix typos (#20118) (Pixel998)c7f861bdocs: Update README (GitHub Actions Bot)6b0c08bdocs: Update README (GitHub Actions Bot)91f97c5docs: Update README (GitHub Actions Bot)Chores
12411e8chore: upgrade @eslint/js@9.36.0 (#20139) (Milos Djermanovic)488cba6chore: package.json update for @eslint/js release (Jenkins)bac82a2ci: simplify renovate configuration (#19907) (唯然)c00bb37ci: bump actions/labeler from 5 to 6 (#20090) (dependabot[bot])fee751drefactor: usedefaultOptionsin rules (#20121) (Pixel998)1ace67dchore: update example to usedefineConfig(#20111) (루밀LuMir)4821963test: add missing loc information to error objects in rule tests (#20112) (루밀LuMir)b42c42echore: disallow use of deprecatedtypeproperty in core rule tests (#20094) (Milos Djermanovic)7bb498dtest: remove deprecatedtypeproperty from core rule tests (#20093) (Pixel998)e10cf2aci: bump actions/setup-node from 4 to 5 (#20089) (dependabot[bot])5cb0ce4refactor: usemeta.defaultOptionsinpreserve-caught-error(#20080) (Pixel998)f9f7cb5chore: package.json update for eslint-config-eslint release (Jenkins)81764b2chore: updateeslintpeer dependency ineslint-config-eslint(#20079) (Milos Djermanovic)v9.35.0Compare Source
Features
42761fafeat: implement suggestions for no-empty-function (#20057) (jaymarvelz)102f444feat: implement suggestions for no-empty-static-block (#20056) (jaymarvelz)e51fffffeat: addpreserve-caught-errorrule (#19913) (Amnish Singh Arora)Bug Fixes
10e7ae2fix: update uncloneable options error message (#20059) (soda-sorcery)bfa4601fix: ignore empty switch statements with comments in no-empty rule (#20045) (jaymarvelz)dfd11defix: addbeforeandafterto test case types (#20049) (Francesco Trotta)dabbe95fix: correct types forno-restricted-importsrule (#20034) (Milos Djermanovic)ea789c7fix: no-loss-of-precision false positive with uppercase exponent (#20032) (sethamus)Documentation
d265515docs: improve phrasing - "if" → "even if" from getting-started section (#20074) (jjangga0214)a355a0edocs: invert comparison logic for example inno-vardoc page (#20064) (OTonGitHub)5082fc2docs: Update README (GitHub Actions Bot)99cfd7edocs: add missing "the" in rule deprecation docs (#20050) (Josh Goldberg ✨)6ad8973docs: update--no-ignoreand--ignore-patterndocumentation (#20036) (Francesco Trotta)8033b19docs: add documentation for--no-config-lookup(#20033) (Francesco Trotta)Chores
da87f2fchore: upgrade @eslint/js@9.35.0 (#20077) (Milos Djermanovic)af2a087chore: package.json update for @eslint/js release (Jenkins)7055764test: removetests/lib/eslint/eslint.config.js(#20065) (Milos Djermanovic)84ffb96chore: update@eslint-community/eslint-utils(#20069) (Francesco Trotta)d5ef939refactor: remove deprecatedcontext.parserOptionsusage across rules (#20060) (sethamus)1b3881dchore: remove redundant word (#20058) (pxwanglu)v9.34.0Compare Source
Features
0bb777afeat: multithread linting (#19794) (Francesco Trotta)43a5f9efeat: add eslint-plugin-regexp to eslint-config-eslint base config (#19951) (Pixel998)Bug Fixes
9b89903fix: default value of accessor-pairs option in rule.d.ts file (#20024) (Tanuj Kanti)6c07420fix: fix spurious failure in neostandard integration test (#20023) (Kirk Waiblinger)676f4acfix: allow scientific notation with trailing zeros matching exponent (#20002) (Sweta Tanwar)Documentation
0b4a590docs: make rulesdir deprecation clearer (#20018) (Domenico Gemoli)327c672docs: Update README (GitHub Actions Bot)bf26229docs: Fix typo in core-concepts/index.md (#20009) (Tobias Hernstig)2309327docs: fix typo in the "Configuring Rules" section (#20001) (ghazi-git)2b87e21docs: [no-else-return] clarify sample code. (#19991) (Yuki Takada (Yukinosuke Takada))c36570cdocs: Update README (GitHub Actions Bot)Chores
f19ad94chore: upgrade to@eslint/js@9.34.0(#20030) (Francesco Trotta)b48fa20chore: package.json update for @eslint/js release (Jenkins)4bce8a2chore: package.json update for eslint-config-eslint release (Jenkins)0c9999crefactor: prefer default options ingrouped-accessor-pairs(#20028) (루밀LuMir)d503f19ci: fixstale.yml(#20010) (루밀LuMir)e2dc67dci: centralizestale.yml(#19994) (루밀LuMir)7093cb8ci: bump actions/checkout from 4 to 5 (#20005) (dependabot[bot])v9.33.0Compare Source
Features
e07820efeat: add global object access detection to no-restricted-globals (#19939) (sethamus)90b050efeat: support explicit resource management inone-var(#19941) (Sweta Tanwar)Bug Fixes
Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, on day 1 of the month ( * 0-3 1 * * ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.